-
Notifications
You must be signed in to change notification settings - Fork 36
Updates to allow building with Visual Studio 2022 #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…Remove CBT build files.
Fix a bug where CQ depths were set to the number of SGEs which does not make sense. Allow memory deregistration to complete asynchronously in the NdMrDeregister test. Determine the maximum supported queue depths before creating a CQ in the NdQpMaxAll test.
|
@microsoft-github-policy-service agree |
|
Is anyone going to review this? |
…ibraries and do not require any Visual C runtime to be installed.
…o fail. Make destructors in base classes virtual.
|
First of all, thank you for adding VS2022 support! I'm just trying to use Network Direct with VS2022. |
Hi, without the static MFC linking, the executables created will work on the system on which they were built, but if you take them to another machine they will not work because they will have a dependency on VisualC runtime. Using static MFC linking allows the .exe files to run on any machine with no dependencies on a runtime package. |
|
Thanks for the explanation. However, I suppose there's a misunderstanding here. Static MFC linking is completely different from MSVC Runtime dependencies. If you want the exe to run without dependencies, you should use the /MT compiler flag to statically link the Runtime. |
Oh yes, you are right. The dependency was in fact on the runtime and not MFC. I will remove MFC and set the code generation runtime option to not use DLL as you suggested. |
… non working 32bit builds.
Please accept this pull request which updates all project and solutions to enable building with Visual Studio 2022. Also fix CQ depth issues and correct a problem where QP creation will fail on adapters where maxSQ and maxRQ depths are not equal.