Skip to content

fix: Bug fix of #20489 #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 11, 2025
Merged

fix: Bug fix of #20489 #321

merged 2 commits into from
Jul 11, 2025

Conversation

Ravikirana-Microsoft
Copy link
Contributor

Purpose

This pull request enhances the functionality of the TaskDetails component by introducing asynchronous handling and loading states for approval and rejection actions. These changes improve user experience by preventing multiple interactions while an action is being processed.

Enhancements to TaskDetails component:

  • Approval Button Logic:

    • Updated the onClick handler for the approval button to use an asynchronous function. This function sets a loading state for the corresponding step, calls the preOnApproved function, and ensures the loading state is removed after the API call completes.
    • Added a disabled attribute to prevent interaction when the step is loading or when canInteract is false.
  • Rejection Button Logic:

    • Updated the onClick handler for the rejection button to use an asynchronous function, mirroring the logic of the approval button. It sets a loading state, calls the preOnRejected function, and removes the loading state after the API call completes.
    • Added a disabled attribute to prevent interaction under the same conditions as the approval button.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

@Roopan-Microsoft Roopan-Microsoft merged commit 5affea6 into dev Jul 11, 2025
7 checks passed
Copy link

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Ravikirana-Microsoft Ravikirana-Microsoft deleted the macae-bu-fixes branch July 17, 2025 14:35
blessing-msft pushed a commit that referenced this pull request Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants