Skip to content

ci: smoke test case integration#328

Merged
Prajwal-Microsoft merged 16 commits intomainfrom
psl-test-integrate
Jan 28, 2026
Merged

ci: smoke test case integration#328
Prajwal-Microsoft merged 16 commits intomainfrom
psl-test-integrate

Conversation

@Kanchan-Microsoft
Copy link
Contributor

Purpose

This pull request introduces several improvements to the deployment workflows and enhances the E2E test automation and coverage. The main changes include adding WAF-specific deployment steps, improving test reporting, and significantly expanding the E2E test page object to support more robust file upload and validation scenarios.

Deployment workflow improvements:

  • Added steps in both .github/workflows/job-deploy-linux.yml and .github/workflows/job-deploy-windows.yml to remove the APPLICATIONINSIGHTS_CONNECTION_STRING environment variable from the backend container app when WAF is enabled, ensuring compatibility with WAF deployments.

Test automation enhancements:

  • Updated .github/workflows/test-automation-v2.yml to:
    • Run a specific pytest marker for "GoldenPath-Testing" and collect screenshots as artifacts for improved debugging and reporting.
  • Updated .gitignore to exclude large SQL files in Large_File directories from version control.

E2E test coverage and code improvements:

  • Refactored and expanded HomePage.py:
    • Added new locators and methods to support bulk file upload, unsupported file validation, harmful file handling, and file removal scenarios.
    • Improved logging and error handling for better traceability during test runs.
    • Updated file paths to use new directory structure for test data (e.g., Valid_files, Invalid_files, Unsupported_files, Harmful_file).

Does this introduce a breaking change?

  • Yes
  • No

Golden Path Validation

  • I have tested the primary workflows (the "golden path") to ensure they function correctly without errors.

Deployment Validation

  • I have validated the deployment process successfully and all services are running as expected with this change.

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request introduces comprehensive E2E test automation improvements and WAF deployment support for the "Modernize Your Code" accelerator. The changes expand test coverage with new test scenarios, enhance reporting with screenshot capture on failures, and add deployment workflow steps to handle WAF-specific configuration requirements.

Changes:

  • Added E2E test enhancements including new test cases for file upload limits, file removal, batch history deletion, unsupported file validation, and harmful file handling
  • Implemented screenshot capture on test failures and improved HTML reporting with step-by-step details
  • Added WAF deployment support by removing APPLICATIONINSIGHTS_CONNECTION_STRING environment variable from backend container apps when WAF is enabled

Reviewed changes

Copilot reviewed 33 out of 40 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
tests/e2e-test/tests/test_codegen_gp_tc.py Refactored from parameterized tests to individual test functions with 6 new test scenarios covering file upload, translation, and validation workflows
tests/e2e-test/tests/conftest.py Added screenshot capture on test failure, enhanced HTML reporting with subtests, and updated report title
tests/e2e-test/pages/HomePage.py Expanded page object with 20+ new methods and locators supporting bulk upload, file removal, unsupported/harmful file validation
tests/e2e-test/pages/loginPage.py Removed super().init() call for consistency
tests/e2e-test/pytest.ini Added 'gp' pytest marker for Golden Path tests
tests/e2e-test/testdata/Valid_files/*.sql Added 20 SQL test files (Informix and T-SQL) for comprehensive testing
tests/e2e-test/testdata/Unsupported_files/* Added unsupported file types for validation testing (txt, json, docx, pdf)
tests/e2e-test/.gitignore Excluded large SQL files from version control
.github/workflows/test-automation-v2.yml Added pytest marker support for GoldenPath-Testing and screenshot artifact collection
.github/workflows/job-deploy-linux.yml Added WAF workaround to remove APPLICATIONINSIGHTS_CONNECTION_STRING from backend container app
.github/workflows/job-deploy-windows.yml Added WAF workaround to remove APPLICATIONINSIGHTS_CONNECTION_STRING from backend container app

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Prajwal-Microsoft Prajwal-Microsoft merged commit e5ac542 into main Jan 28, 2026
37 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants