ci: smoke test case integration#328
Merged
Prajwal-Microsoft merged 16 commits intomainfrom Jan 28, 2026
Merged
Conversation
Updated pytest command to include correct marker syntax and added screenshot path to artifact upload.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces comprehensive E2E test automation improvements and WAF deployment support for the "Modernize Your Code" accelerator. The changes expand test coverage with new test scenarios, enhance reporting with screenshot capture on failures, and add deployment workflow steps to handle WAF-specific configuration requirements.
Changes:
- Added E2E test enhancements including new test cases for file upload limits, file removal, batch history deletion, unsupported file validation, and harmful file handling
- Implemented screenshot capture on test failures and improved HTML reporting with step-by-step details
- Added WAF deployment support by removing
APPLICATIONINSIGHTS_CONNECTION_STRINGenvironment variable from backend container apps when WAF is enabled
Reviewed changes
Copilot reviewed 33 out of 40 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/e2e-test/tests/test_codegen_gp_tc.py | Refactored from parameterized tests to individual test functions with 6 new test scenarios covering file upload, translation, and validation workflows |
| tests/e2e-test/tests/conftest.py | Added screenshot capture on test failure, enhanced HTML reporting with subtests, and updated report title |
| tests/e2e-test/pages/HomePage.py | Expanded page object with 20+ new methods and locators supporting bulk upload, file removal, unsupported/harmful file validation |
| tests/e2e-test/pages/loginPage.py | Removed super().init() call for consistency |
| tests/e2e-test/pytest.ini | Added 'gp' pytest marker for Golden Path tests |
| tests/e2e-test/testdata/Valid_files/*.sql | Added 20 SQL test files (Informix and T-SQL) for comprehensive testing |
| tests/e2e-test/testdata/Unsupported_files/* | Added unsupported file types for validation testing (txt, json, docx, pdf) |
| tests/e2e-test/.gitignore | Excluded large SQL files from version control |
| .github/workflows/test-automation-v2.yml | Added pytest marker support for GoldenPath-Testing and screenshot artifact collection |
| .github/workflows/job-deploy-linux.yml | Added WAF workaround to remove APPLICATIONINSIGHTS_CONNECTION_STRING from backend container app |
| .github/workflows/job-deploy-windows.yml | Added WAF workaround to remove APPLICATIONINSIGHTS_CONNECTION_STRING from backend container app |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Prajwal-Microsoft
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request introduces several improvements to the deployment workflows and enhances the E2E test automation and coverage. The main changes include adding WAF-specific deployment steps, improving test reporting, and significantly expanding the E2E test page object to support more robust file upload and validation scenarios.
Deployment workflow improvements:
.github/workflows/job-deploy-linux.ymland.github/workflows/job-deploy-windows.ymlto remove theAPPLICATIONINSIGHTS_CONNECTION_STRINGenvironment variable from the backend container app when WAF is enabled, ensuring compatibility with WAF deployments.Test automation enhancements:
.github/workflows/test-automation-v2.ymlto:.gitignoreto exclude large SQL files inLarge_Filedirectories from version control.E2E test coverage and code improvements:
HomePage.py:Valid_files,Invalid_files,Unsupported_files,Harmful_file).Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information