Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes default value apply of JournalingReportNdrTo in EXO Transport Config #5851

Open
wants to merge 2 commits into
base: Dev
Choose a base branch
from

Conversation

FabienTschanz
Copy link
Collaborator

Pull Request (PR) description

This PR fixes an issue where the default value <> of JournalingReportNdrTo in the EXOTransportConfig could be applied to the tenant, which will throw an exception. If the default value or an empty string is present, the property won't be applied because it has to be a valid email address. Once set, the setting cannot be removed.

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@ricmestre
Copy link
Contributor

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG:EXOTransportConfig :System.InvalidOperationException|Before you create a journal rule
2 participants