Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXOMalwareFilterRule: Fix for issue #1213 #1215

Merged
merged 6 commits into from
May 26, 2021
Merged

Conversation

stvnmbr1
Copy link
Contributor

@stvnmbr1 stvnmbr1 commented May 19, 2021

Pull Request (PR) description

EXOMalwareFilterRule: Fix for issue #1213
Policy X already has rule Y associated with it

This Pull Request (PR) fixes the following issues

Fixes #1213
Policy X already has rule Y associated with it


This change is Reviewable

stvnmbr1 added 3 commits May 12, 2021 13:23
The parameter is not available for New-OfflineAddressBook

PS error:
A parameter cannot be found that matches parameter name 'ConfiguredAttributes'

Microsoft Doc
https://docs.microsoft.com/en-us/powershell/module/exchange/new-offlineaddressbook?view=exchange-ps
Remove MalwareFilterPolicy from MalwareFilterRuleParams before invoking Set-MalwareFilterRule, if the set MalwareFilterPolicy is not equal to MalwareFilterPolicy retrieved from the existing rule
@stvnmbr1 stvnmbr1 requested a review from NikCharlebois as a code owner May 19, 2021 13:13
stvnmbr1 added 2 commits May 19, 2021 17:04
EXOSafeAttachmentRule: Fix for issue microsoft#1213
Policy X already has rule Y associated with it if rule exists already
@stvnmbr1
Copy link
Contributor Author

added EXOSafeAttachmentRule: Fix for issue #1213
Policy X already has rule Y associated with it if rule exists already

Can you confirm only one Safe Attachment Rule per Safe Attachment Policy is allowed?

add SafeLinksRuleParams instead of PSBoundParameters for Set-EXOSafeLinksRule
Fix editing an existing rule - policy already has rule assigned error
@stvnmbr1
Copy link
Contributor Author

added EXOSafeLinksRule: Fix for issue #1213
Policy X already has rule Y associated with it if rule exists already

Can you confirm also only one Safe Links Rule per Safe Links Policy is allowed?

Copy link
Collaborator

@desmay desmay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @NikCharlebois)

@desmay desmay merged commit c693c9d into microsoft:Dev May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Policy X already has rule Y associated with it
2 participants