Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multitasking #139

Merged
merged 9 commits into from
Nov 3, 2024
Merged

add support for multitasking #139

merged 9 commits into from
Nov 3, 2024

Conversation

zainadr
Copy link
Contributor

@zainadr zainadr commented Oct 29, 2024

No description provided.

@zainadr
Copy link
Contributor Author

zainadr commented Oct 29, 2024 via email

@IdanGoldfarb1989
Copy link
Contributor

Sanity question:
You're only adding a handler to onInit, meaning that all other actions will still have the bug where the extension name is null. Are we certain this isn’t causing additional issues?
Are exceptions being thrown on the client side because of this?

If possible, I suggest adding actions and handlers with basic functionality to all tab operations to prevent the broken state where extensionName is NULL.

Frontend/src/index.ui.tsx Outdated Show resolved Hide resolved
Frontend/tools/BaseTab.js Show resolved Hide resolved
Frontend/tools/Internal/InternalTab.js Show resolved Hide resolved
Frontend/tools/Internal/InternalTab.js Show resolved Hide resolved
Frontend/tools/PublicToInternalTransformer.js Outdated Show resolved Hide resolved
Frontend/src/models/SampleWorkloadModel.ts Outdated Show resolved Hide resolved
@zainadr zainadr merged commit 9dc22ae into main Nov 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants