Skip to content

Update CI conda deps to match training/scoring SDK #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2020
Merged

Conversation

tcare
Copy link
Contributor

@tcare tcare commented Apr 13, 2020

  • Tied SDK version to 1.2.x as with conda_dependencies.yml
  • Allow deps to fall out based on SDK
  • Kept the rest of the deps manually specified to keep image size small and minimize regressions

Passing build at https://aidemos.visualstudio.com/MLOps/_build/results?buildId=4388&view=results

Test image deployed at mcr.microsoft.com/mlops/python:tcare-test

- Tied SDK version to 1.2.x as with conda_dependencies.yml
- Allow deps to fall out based on SDK
- Kept the rest of the deps manually specified to keep image size small and minimize regressions
@tcare tcare requested review from eedorenko, sudivate and dtzar April 13, 2020 17:57
@sudivate
Copy link
Contributor

@tcare explicitly specifying the versions for the dependencies will be safer.

@tcare
Copy link
Contributor Author

tcare commented Apr 13, 2020

Explicitly setting for the top level SDK and letting it resolve its dependency tree should be sufficient for most. However we should probably manually specify pip as well.

Edit: we can also freeze these at the new versions if you like, however at least letting point versions update would be preferable. I feel we're going to get breaks either way, but specifying the larger top level dependencies should reduce most of the pain.

@tcare
Copy link
Contributor Author

tcare commented Apr 13, 2020

For the CI image in particular, this would also let us update the image easily if there was a needed update from one of these deps. Otherwise the image will stay static since we deploy it manually and version tag it.

@dtzar
Copy link
Contributor

dtzar commented Apr 13, 2020

I'm fine to lock at bug fix (i.e. 1.4.x) but no more loose than this. We've had a bunch of problems with deps breaking things in the past leaving no versions on (as you currently have in the PR).

@tcare
Copy link
Contributor Author

tcare commented Apr 13, 2020

Do we know which ones in particular were causing issues? I didn't see too many in the yml file histories (apart from azure-cli which needed updating due to an upstream change)

@tcare
Copy link
Contributor Author

tcare commented Apr 13, 2020

Versions have been locked down and a successful run is at https://aidemos.visualstudio.com/MLOps/_build/results?buildId=4391&view=results

@tcare tcare merged commit d0e91cf into master Apr 13, 2020
@tcare tcare deleted the tcare/ci-deps branch April 13, 2020 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants