Skip to content

Canary pipeline fixes #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 9, 2020
Merged

Canary pipeline fixes #224

merged 2 commits into from
Mar 9, 2020

Conversation

tcare
Copy link
Contributor

@tcare tcare commented Mar 9, 2020

  • Use the variable template so we don't have to manually define MODEL_NAME and MODEL_VERSION
  • Upgrade helm version to 3.1.1 to fix some issues
  • Enable ACR authentication using service principals rather than a manual secret

tcare added 2 commits March 9, 2020 15:18
- Upgrade helm version to 3.1.1
- Remove ACR secret from the abtest-model deployment
@tcare tcare requested review from dtzar, jotaylo and eedorenko March 9, 2020 22:22
@tcare tcare merged commit 86c6a1f into master Mar 9, 2020
@tcare tcare deleted the tcare/abtest-fixes branch March 9, 2020 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants