Skip to content

Modified to use dataset and pipelinedata #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 14, 2020
Merged

Conversation

GraemeMalcolm
Copy link
Contributor

I modified the pipeline to be more "AMLish":

  • Added instructions to Getting Started to register a dataset (or set variables for the pipeline to do it for you)
  • Used input in training step to pass dataset object
  • Added pipelinedata object to pass trained model as output from train step and input to register step

@GraemeMalcolm
Copy link
Contributor Author

I'm getting a "Bad Gateway" error in the smoke test after the model service is deployed. I don't think this is due to my changes - it looks like an AML service error, but we should probably hold off on merging until we troublehoot it.

Copy link
Contributor

@dtzar dtzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, since we're no longer using the other two DATA env variables, you should remove them everywhere.

@GraemeMalcolm GraemeMalcolm merged commit 88636df into master Feb 14, 2020
@dtzar dtzar deleted the gmalc-aml-ization branch February 14, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants