-
Notifications
You must be signed in to change notification settings - Fork 75
CI Fixups #994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Fixups #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a change in the latest version of conda that requires explicit acceptance of terms of service to prevent CI pipeline failures. The changes ensure conda operates in a non-interactive mode suitable for CI environments.
- Adds
CONDA_NO_PROGRESS_BARS=1environment variable across CI workflows and build configurations - Explicitly accepts conda terms of service for required channels in Docker setup
- Enables debug output (
set -x) in Docker build for better troubleshooting
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Makefile | Sets and exports CONDA_NO_PROGRESS_BARS environment variable |
| .github/workflows/macos.yml | Adds CONDA_NO_PROGRESS_BARS=1 to macOS CI environment |
| .github/workflows/linux.yml | Adds CONDA_NO_PROGRESS_BARS=1 to Linux CI environment |
| .devcontainer/Dockerfile | Adds debug output, progress bar suppression, and explicit ToS acceptance for conda channels |
for more information, see https://pre-commit.ci
motus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you!
# Pull Request ## Title Split docker test fixtures ______________________________________________________________________ ## Description Splits docker test fixtures so that individual docker-compose projects can be setup and torn down independently. This improves single test performance (e.g., when SQL tests don't need to setup SSH test fixtures) and parallelism by allowing each to operate independently. ______________________________________________________________________ ## Type of Change - 🔄 Refactor - 🧪 Tests ______________________________________________________________________ ## Additional Notes (optional) Should be merged after #994 ______________________________________________________________________ --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Pull Request
Title
CI Fixups
Description
Pull prebuilt
pyrfrfrom conda to workaround devcontainer build error with pyrfr #1001Continue using debian
bookwormbase untilazure-cliadds support fortrixiedevcontainer missing azure-cli error #1002.See Also:
Type of Change
Testing
CI Pipeline runs again.