Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy static type checking for mlos_bench #306

Merged
merged 137 commits into from
Apr 19, 2023
Merged

mypy static type checking for mlos_bench #306

merged 137 commits into from
Apr 19, 2023

Conversation

bpkroth
Copy link
Contributor

@bpkroth bpkroth commented Apr 13, 2023 •
edited
Loading

Adds static type checking via mypy for mlos_bench as well.

Builds on #305, #307

  • Add Protocols for different Service types so Environments can check that the appropriate Service mix-ins have been setup.
    • Config Loader
    • Local Exec
    • Remote Exec
    • Remote Fileshare
    • VM Ops
      • Future PR: Split VM Ops to VM/Host and OS Ops (for local SSH support)

bpkroth and others added 30 commits April 11, 2023 21:32
@bpkroth
mypy type checking support for mlos_core (mlos_bench to follow later)
083e347
@bpkroth
remove a comment
88ef7bb
@bpkroth
more spelling changes
228d977
@bpkroth
more spelling issues
6a8622b
@bpkroth
ignore that line
6160ad5
@bpkroth
license headers
6a8c4b0
@bpkroth
Merge branch 'main' into mypy-typing-mlos_core
5c29b3b
@bpkroth
test fixups
2e4c8b4
@bpkroth
make more test dynamic
c00ab7f
@bpkroth
stub files to make mypy not complain about multiple conftest.py
795ee8a
@bpkroth
enable mypy for mlos_bench
5d9ffac
@bpkroth
ignore missing matplotlib stubs
03454f0
@bpkroth
ignore setup.py errors
5a68d29
@bpkroth
Merge remote-tracking branch 'upstream/main' into mypy-typing-mlos_bench
b1fa37e
@bpkroth
Merge remote-tracking branch 'upstream/main' into mypy-typing-mlos_bench
7eb1877
@bpkroth
add some ignores
5b93328
@bpkroth
type check fixups
b7a7647
@bpkroth
more strict return values
7f46392
@bpkroth
more type tweaks
0179ca7
@bpkroth
wip: more typing fixups
8032064
@bpkroth
wip: typing
8b8aadc
@bpkroth
force function definitions to have type decorations
6fcc9ff
@bpkroth
type annotations
a0fa181
@bpkroth
ignore errors on listening to port 81 from 127.0.0.1 so we can run tw…
f6ee713 
…o devcontainer instances at a time
@bpkroth
more type check fixups
db83926
@bpkroth
ignore missing matplotlib stubs
d281668
@bpkroth
more typing
15286a2
@bpkroth
spelling
25a5403
@bpkroth
annotate test functions
c4261df
@bpkroth
spelling
9a3242d
@bpkroth bpkroth added the ready for review Ready for review label Apr 17, 2023
motus
motus approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@motus motus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it! left a few nitpick comments

mlos_bench/mlos_bench/environment/base_environment.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/environment/base_environment.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/environment/base_environment.py Show resolved Hide resolved
mlos_bench/mlos_bench/environment/base_environment.py Show resolved Hide resolved
mlos_bench/mlos_bench/environment/base_environment.py Show resolved Hide resolved
mlos_bench/mlos_bench/tests/optimizer/toy_optimization_loop_test.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/tests/service/remote/azure/azure_fileshare_test.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/tests/tunables/tunables_copy_test.py Show resolved Hide resolved
mlos_bench/mlos_bench/tunables/tunable_groups.py Outdated Show resolved Hide resolved
mlos_bench/mlos_bench/tunables/tunable_groups.py Outdated Show resolved Hide resolved
@bpkroth bpkroth enabled auto-merge (squash) April 19, 2023 18:27
@bpkroth bpkroth merged commit 9fe180a into microsoft:main Apr 19, 2023
@bpkroth bpkroth deleted the mypy-typing-mlos_bench branch April 19, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@motus motus motus approved these changes

Assignees
No one assigned
Labels
ready for review Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bpkroth @motus