Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated column for R #317 #319

Merged
merged 15 commits into from
Aug 30, 2021
Merged

updated column for R #317 #319

merged 15 commits into from
Aug 30, 2021

Conversation

priyankkhanna
Copy link
Contributor

will this work?

@priyankkhanna
Copy link
Contributor Author

haven't added link as right now i am not aware of the appropriate link

@priyankkhanna
Copy link
Contributor Author

markdown files for R lessons are named as .Rmd. Shouldn't they be R.md?

Copy link
Contributor

@jlooper jlooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, this is better, but looks odd on mobile. Can you add bullets:

  • Python
  • R

if there are no R lessons, let’s not include the link. If there are, you can link to the R lesson notebook which are in /solution/R - they start in the Regression lesson area.

Also, let’s add the author credit in the last column: Eric Wanjau (R) if there is a lesson.

Thank you! And thanks @alfredodeza for the guidance too - a better solution than more columns!

@priyankkhanna
Copy link
Contributor Author

on it

@priyankkhanna
Copy link
Contributor Author

will this work? @jlooper

@priyankkhanna
Copy link
Contributor Author

is there anything i need to work that i am missing?

@alfredodeza
Copy link
Collaborator

alfredodeza commented Aug 27, 2021

@priyankkhanna this looks almost good to go. It seems you are missing a couple of rows as shown here (they should say Python instead of Lesson right?):

Screen Shot 2021-08-27 at 9 14 51 AM

And if you could squash some of the error-fixing commits, that would be 💯

@jlooper
Copy link
Contributor

jlooper commented Aug 27, 2021

@R-icntay the .Rmd files have this suffix for a reason, right? We shouldn’t change those, I believe

@jlooper
Copy link
Contributor

jlooper commented Aug 27, 2021

is there anything i need to work that i am missing?

The column header should only be titled “Linked Lesson”

@R-icntay
Copy link
Contributor

@R-icntay the .Rmd files have this suffix for a reason, right? We shouldn’t change those, I believe

Yes yes @jlooper , .Rmd files represent the native R Notebooks that can be run on RStudio or VS code. They are similar to .ipynb Notebooks for Python

@priyankkhanna
Copy link
Contributor Author

@alfredodeza. Yes you are right. But if you go through them they do not touch any language as such. Apart from 1st that does only says a bit about python. Still I can change 1st lesson to python or all.
Let me know what you think I will update it respectively.

and ok. I will correct those Rmd modifications i did

@priyankkhanna
Copy link
Contributor Author

Please check it now @jlooper, @R-icntay

thanks for pointing that out @jlooper.
Copy link
Contributor

@jlooper jlooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, looking at the markup, two changes please:

You can create bullets in markdown by using - rather than adding html, so let's edit out the <ul> and <li> to simplify the markdown.

The last lesson should be listed as 'lesson' (Real World) as there's no code associated to that lesson.

@priyankkhanna
Copy link
Contributor Author

I tried using - but it is not working properly inside table that's why I switched to html.
In table - is not doing well.

Tables Are
col 3 is - first - second
col 2 is centered
Tables Are
col 3 is - first
  • second |
    | col 2 is | centered |

@jlooper jlooper merged commit d94937c into microsoft:main Aug 30, 2021
spicyneutrino pushed a commit to spicyneutrino/ML-For-Beginners that referenced this pull request Jan 1, 2025
* updated column for R microsoft#317

will this work?

* removed some minor errors

* updated name of lesson 1

* updated name lesson2

* updated name of lesson 3

* updated name of lesson 4R

* updated columns as asked

* reverted to .Rmd

* reverted to .Rmd

* reverted to .Rmd

* reverted to .Rmd

* corrected R links

* corrected wrong links of R

* updated column header to linked lesson

thanks for pointing that out @jlooper.

* in last column changed python to lesson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants