-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated column for R #317 #319
Conversation
will this work?
haven't added link as right now i am not aware of the appropriate link |
markdown files for R lessons are named as .Rmd. Shouldn't they be R.md? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, this is better, but looks odd on mobile. Can you add bullets:
- Python
- R
if there are no R lessons, let’s not include the link. If there are, you can link to the R lesson notebook which are in /solution/R - they start in the Regression lesson area.
Also, let’s add the author credit in the last column: Eric Wanjau (R) if there is a lesson.
Thank you! And thanks @alfredodeza for the guidance too - a better solution than more columns!
on it |
will this work? @jlooper |
is there anything i need to work that i am missing? |
@priyankkhanna this looks almost good to go. It seems you are missing a couple of rows as shown here (they should say Python instead of Lesson right?): And if you could squash some of the error-fixing commits, that would be 💯 |
@R-icntay the .Rmd files have this suffix for a reason, right? We shouldn’t change those, I believe |
The column header should only be titled “Linked Lesson” |
@alfredodeza. Yes you are right. But if you go through them they do not touch any language as such. Apart from 1st that does only says a bit about python. Still I can change 1st lesson to python or all. and ok. I will correct those Rmd modifications i did |
thanks for pointing that out @jlooper.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi, looking at the markup, two changes please:
You can create bullets in markdown by using -
rather than adding html, so let's edit out the <ul> and <li>
to simplify the markdown.
The last lesson should be listed as 'lesson' (Real World) as there's no code associated to that lesson.
I tried using - but it is not working properly inside table that's why I switched to html.
|
* updated column for R microsoft#317 will this work? * removed some minor errors * updated name of lesson 1 * updated name lesson2 * updated name of lesson 3 * updated name of lesson 4R * updated columns as asked * reverted to .Rmd * reverted to .Rmd * reverted to .Rmd * reverted to .Rmd * corrected R links * corrected wrong links of R * updated column header to linked lesson thanks for pointing that out @jlooper. * in last column changed python to lesson
will this work?