Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add vllm support for 0.4.2 and 0.4.3 #19

Merged
merged 2 commits into from
Jul 7, 2024
Merged

add vllm support for 0.4.2 and 0.4.3 #19

merged 2 commits into from
Jul 7, 2024

Conversation

liyucheng09
Copy link
Contributor

@liyucheng09 liyucheng09 commented Jul 5, 2024 •
edited
Loading

What does this PR do?

This PR add vllm support for 0.4.2 and 0.4.3.

Fixes #13 .

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Was this discussed/approved via a Github issue? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Who can review?

@iofu728

@iofu728 iofu728 added bug Something isn't working documentation Improvements or additions to documentation labels Jul 6, 2024
@iofu728 iofu728 merged commit dbe9029 into main Jul 7, 2024
1 check passed
@iofu728 iofu728 deleted the vllm-dev branch July 7, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iofu728 iofu728 iofu728 approved these changes

Assignees

@liyucheng09 liyucheng09

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Question]: python run_vllm.py TypeError: 'type' object is not subscriptable
2 participants
@liyucheng09 @iofu728