Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python] prepare for PyPI #635

Merged
merged 26 commits into from
Jun 20, 2017
Merged

[python] prepare for PyPI #635

merged 26 commits into from
Jun 20, 2017

Conversation

guolinke
Copy link
Collaborator

No description provided.

@henry0312
Copy link
Contributor

henry0312 commented Jun 19, 2017

typo: PyPI (pypi), not pipy :)

@guolinke guolinke changed the title [python] prepare for pipy [python] prepare for PyPI Jun 19, 2017
@henry0312
Copy link
Contributor

henry0312 commented Jun 19, 2017

I can do refactoring setup.py after merge.

@guolinke
Copy link
Collaborator Author

@henry0312 can you refactor it base on this branch, then creat a PR to that branch?

@henry0312
Copy link
Contributor

@guolinke yes, I can, but I'll have been busy until the end of June.
So I think It's better to merge this PR for now.

@guolinke
Copy link
Collaborator Author

@wxchan any comments?

@wxchan
Copy link
Contributor

wxchan commented Jun 19, 2017

Is it possible to remove --precompile and infer whether it's precompiled? like run find_packages first and see if it's an exception?

@wxchan
Copy link
Contributor

wxchan commented Jun 19, 2017

MANIFEST.in can be simplified a little:

warning: no files found matching '*.md'
warning: no files found matching '*' under directory 'include'
warning: no files found matching '*' under directory 'src'
warning: no previously-included files matching '*.o' found anywhere in distribution
warning: no previously-included files matching '*.obj' found anywhere in distribution
warning: no previously-included files matching '*.a' found anywhere in distribution
warning: no previously-included files matching '*.pyo' found anywhere in distribution
warning: no previously-included files matching '*.pyc' found anywhere in distribution

build_pip.py seems not necessary? we can run python setup.py sdist directly

@guolinke
Copy link
Collaborator Author

guolinke commented Jun 19, 2017

@wxchan
I think the default option should be re-compile, since it is more safe if updating the cpp codes.

@wxchan
Copy link
Contributor

wxchan commented Jun 19, 2017

ok, hope it wouldn't be confused to old users.

what is the getopt error you talked about yesterday?

@guolinke
Copy link
Collaborator Author

@wxchan
Copy link
Contributor

wxchan commented Jun 19, 2017

ok, no other issue.

@guolinke
Copy link
Collaborator Author

@wxchan
after build the package, i try to install it via pip install lightgbm-0.2a0.tar.gz.
But it shows a strange error : No files/directories in C:\Users\xxx\AppData\Local\Temp\pip-vfzusp1m-build\pip-egg-info (from PKG-INFO)

Do you have any idea about this ?

use_precompile = True
except getopt.GetoptError as err:
pass
sys.argv = sys.argv[0:2]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the same error on my mac, fix by removing this line

@guolinke guolinke merged commit 80c641c into master Jun 20, 2017
@guolinke guolinke deleted the python-package branch June 20, 2017 05:53
guolinke added a commit that referenced this pull request Oct 9, 2017
* add make command to the python package.

* Update README.rst

* Update README.rst

* Update README.rst

* fix tests.

* fix unix build

* update readme

* fix setup.py

* update travis

* Update .travis.yml

* Update test.py

* some fixes.

* check the 64-bit python

* fix build.

* refine MANIFEST.in

* update Manifest.in

* add more build options.

* Add fatal in cmake

* fix a endif.

* fix bugs.

* fix pep8

* add test for the pip package build

* add test pip install in travis.

* fix version with pre-compile dll

* fix readme.rst

* update readme
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants