Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] allow more possibly-lost warnings from valgrind #6233

Merged
merged 4 commits into from
Dec 19, 2023

Conversation

jameslamb
Copy link
Collaborator

Contributes to the v4.2.0 release (#6191).

The latest valgrind build showed 1,056 bytes "possibly lost", all from code paths that create threads w/ pthread_create. (#6191 (comment))

In the past, CRAN has allowed some of these as false positives. (#6191 (comment))

This PR proposes modifying the test script for that job to acknowledge that this set of findings from valgrind are allowed.

Notes for Reviewers

It would be better to suppress specific cases instead of do text-parsing to enforce a maximum number of "possibly lost" reported bytes... but that will take a bit more time to develop. I've documented it in #6231 and put good first issue on it to try to increase the likelihood that someone comes and contributes that.

@jameslamb
Copy link
Collaborator Author

jameslamb commented Dec 13, 2023

/gha run r-valgrind

Workflow R valgrind tests has been triggered! 🚀
https://github.com/microsoft/LightGBM/actions/runs/7190693469

Status: success ✔️.

@jameslamb jameslamb mentioned this pull request Dec 13, 2023
24 tasks
@jameslamb jameslamb marked this pull request as ready for review December 13, 2023 13:51
@jameslamb
Copy link
Collaborator Author

Could I please get a review on this this week? This is the last PR I think needs to be done before we put up release v4.2.0 (#6191). I'd like to get that release out this week, to get that quantized training fix (#5994) out to more users.

Copy link
Collaborator

@jmoralez jmoralez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock, hopefully someone else reviews this.

@jameslamb
Copy link
Collaborator Author

Thanks @jmoralez ! I'm going to merge this to continue with testing the release candidate.

For what it's worth, the R package has been up for 11 days now and CRAN has not reported any valgrind issues yet.

image

https://cran.r-project.org/web/checks/check_results_lightgbm.html

@jameslamb jameslamb merged commit 69e3c94 into master Dec 19, 2023
41 checks passed
@jameslamb jameslamb deleted the fix/valgrind-checks branch December 19, 2023 17:19
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants