Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix single row prediction performance in a multi-threaded environment #6024

Merged
merged 25 commits into from
Mar 18, 2024
Merged
Changes from 2 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
e8c316f
Fix single row prediction performance in a multi-threaded environment
Ten0 Aug 6, 2023
fe31d4e
fix missing file change
Ten0 Aug 6, 2023
feaf3dc
fix lint
Ten0 Aug 7, 2023
f41755b
check whether freeze is due to booster shared lock being held by the …
Ten0 Aug 7, 2023
c52a7d7
what you get for having everything as an int
Ten0 Aug 7, 2023
601316b
Merge branch 'master' into 6021-fix_single_row_contention
shiyu1994 Aug 15, 2023
f4cf79d
Merge branch 'master' into 6021-fix_single_row_contention
jameslamb Sep 3, 2023
c7e9d2e
Merge branch 'master' into 6021-fix_single_row_contention
jameslamb Sep 6, 2023
6d949a0
Add TODO about FastConfig naming needing to be updated
Ten0 Jan 11, 2024
1fcbc3f
Add a test showcasing fast single row prediction in multi-thread
Ten0 Jan 11, 2024
4a80c8c
Add a workaround for #6142
Ten0 Jan 12, 2024
a864333
Merge branch '6021-fix_single_row_contention_v4' into 6021-fix_single…
Ten0 Jan 12, 2024
6db33b3
Merge branch 'master' into 6021-fix_single_row_contention
Ten0 Jan 12, 2024
49d7217
add more cleanup comment
Ten0 Jan 12, 2024
1a4f1aa
cleanup some unnecessary includes in the test
Ten0 Jan 12, 2024
bf5fc5f
Merge branch '6021-fix_single_row_contention_v4' into 6021-fix_single…
Ten0 Jan 12, 2024
e00191a
make windows cpp compiler happy
Ten0 Jan 12, 2024
46ca8e6
Merge branch '6021-fix_single_row_contention_v4' into 6021-fix_single…
Ten0 Jan 12, 2024
bfefc20
hopefully make static analysis happy
Ten0 Jan 22, 2024
e0d7913
Merge branch '6021-fix_single_row_contention_v4' into 6021-fix_single…
Ten0 Jan 22, 2024
ff613ad
Turn TODO into a regular comment
Ten0 Jan 24, 2024
063008a
Merge branch '6021-fix_single_row_contention_v4' into 6021-fix_single…
Ten0 Jan 24, 2024
a01916a
Merge remote-tracking branch 'upstream/master' into 6021-fix_single_r…
Ten0 Jan 26, 2024
99140fa
Merge branch 'master' into 6021-fix_single_row_contention
jameslamb Feb 3, 2024
4e29833
Merge branch 'master' into 6021-fix_single_row_contention
jameslamb Mar 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/cpp_tests/test_single_row.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ TEST(SingleRow, JustWorks) {
EXPECT_EQ(0, result) << "LGBM_BoosterPredictForMat result code: " << result;

// Now let's run with the single row fast prediction API:
int n_threads = 10;
const int n_threads = 10;
FastConfigHandle fast_configs[n_threads];
for (int i = 0; i < n_threads; i++) {
result = LGBM_BoosterPredictForMatSingleRowFastInit(
Expand Down
Loading