Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[python-package] make _InnerPredictor construction stricter #5961

Merged
merged 6 commits into from
Jul 14, 2023
Merged

[python-package] make _InnerPredictor construction stricter #5961

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e5d8bb
[python-package] make _InnerPredictor construction stricter
jameslamb Jul 7, 2023
fadb605
make handle non-None
jameslamb Jul 8, 2023
0f92863
docstring
jameslamb Jul 8, 2023
fb06b65
Apply suggestions from code review
jameslamb Jul 12, 2023
0234971
fix docstrings
jameslamb Jul 12, 2023
2d9ded2
Merge branch 'master' into simplify-inner-predictor
jameslamb Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: José Morales <jmoralz92@gmail.com>
  • Loading branch information
@jameslamb @jmoralez
jameslamb and jmoralez authored Jul 12, 2023
commit fb06b652de795fd4f0d87e405e7172befe098c37
4 changes: 2 additions & 2 deletions python-package/lightgbm/basic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -847,7 +847,7 @@ def __init__(

Parameters
----------
booster : Booster
booster_handle : Booster
jmoralez marked this conversation as resolved.
Show resolved Hide resolved
Handle of Booster.
pandas_categorical : list of list, or None
If provided, list of categories for ``pandas`` categorical columns.
Expand Down Expand Up @@ -882,7 +882,7 @@ def from_booster(
Parameters
----------
booster : Booster
Handle of Booster.
Booster.
pred_parameter: dict
Other parameters for the prediction.
"""
Expand Down