move LightGBM-vendored json11 into a LightGBM-specific namespace (fixes #5944) #5946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
jameslamb
requested changes
Jun 26, 2023
There was a problem hiding this comment.
Thanks for this. But before we review, can you please answer the question I asked in #5944 (comment)?
please be more specific about what "conflict" means?
jameslamb
changed the title
jameslamb
changed the title
jameslamb
approved these changes
Jun 29, 2023
There was a problem hiding this comment.
Looks good to me, based on the description you provided in #5944 (comment). Thanks for that!
@guolinke or @shiyu1994 could you please also provide a review?
guolinke
approved these changes
Jun 30, 2023
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LightGBM library includes code from the json11 library (https://github.com/dropbox/json11), with some minor changes for internal use.
When attempting to integrate the LightGBM library into another project that already relies on the unmodified json11 library, it doesn't compile due to multiple definition of methods.
Using a single version of json11 for everything doesn't work because some method signatures were changed in 346db12.
This problem can be easily resolved by changing the namespace, and since this project is the one using a modified version of json11, I think that the change should be implemented here.
Fixes #5944