Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix percentile computation for regression objectives #5848

Merged
merged 6 commits into from
Aug 15, 2023
Merged

fix percentile computation for regression objectives #5848

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8655aa1
Update regression_objective.hpp
zachary62 Apr 24, 2023
d19e4b7
Update regression_objective.hpp
zachary62 May 11, 2023
fc093a7
Merge branch 'master' into master
shiyu1994 Aug 11, 2023
80a2a98
fix position in percentile calculation
shiyu1994 Aug 14, 2023
bd1ae3c
fix regression metric threshold for l1
shiyu1994 Aug 14, 2023
bdcbfb8
Merge branch 'master' into master
shiyu1994 Aug 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update regression_objective.hpp
  • Loading branch information
@zachary62
zachary62 authored Apr 24, 2023
commit 8655aa1fd0391f1bad821cd2fef73358a68f3f35
2 changes: 1 addition & 1 deletion src/objective/regression_objective.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace LightGBM {
for (data_size_t i = 0; i < cnt_data; ++i) { \
ref_data[i] = data_reader(i); \
} \
const double float_pos = static_cast<double>(1.0 - alpha) * cnt_data; \
const double float_pos = static_cast<double>(cnt_data - 1) * alpha; \
const data_size_t pos = static_cast<data_size_t>(float_pos); \
if (pos < 1) { \
return ref_data[ArrayArgs<T>::ArgMax(ref_data)]; \
Expand Down