Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Accept factor labels and use their levels #5341

Merged
merged 23 commits into from
Feb 14, 2023
Merged

[R-package] Accept factor labels and use their levels #5341

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
b311922
accept factors and use their levels
david-cortes Jun 30, 2022
a348c96
linter
david-cortes Jun 30, 2022
e3bcb9c
fix tests
david-cortes Jun 30, 2022
cc55422
fix tests
david-cortes Jun 30, 2022
5d8e175
solve merge conflict
david-cortes Feb 11, 2023
d05d2a6
linter
david-cortes Feb 11, 2023
85c0362
linter
david-cortes Feb 11, 2023
a5204cd
Update R-package/R/lightgbm.R
david-cortes Feb 12, 2023
3781c83
Update R-package/R/lgb.Booster.R
david-cortes Feb 12, 2023
5d7aa3e
Update R-package/R/lightgbm.R
david-cortes Feb 12, 2023
836167c
change list of multiclass objectives to function
david-cortes Feb 12, 2023
58bfe4a
Merge branch 'Rinterface10' of github.com:david-cortes/lightgbm into …
david-cortes Feb 12, 2023
621da38
use keyword arguments with data processor
david-cortes Feb 12, 2023
135786e
check for aliases of num_class
david-cortes Feb 12, 2023
7096dd1
rename 'y' -> 'label'
david-cortes Feb 12, 2023
53b5e9a
use regexp for error tests about binary/multiclass objectives
david-cortes Feb 12, 2023
39fd2df
update docs
david-cortes Feb 12, 2023
3388465
linter
david-cortes Feb 12, 2023
138dac5
use 'lgb.check.wrapper_param' instead of manually modifying 'params'
david-cortes Feb 12, 2023
8b6b346
update objective aliases
david-cortes Feb 12, 2023
1e31200
use more 'binary' aliases
david-cortes Feb 12, 2023
3475f0f
update docs
david-cortes Feb 12, 2023
8ef8e56
remove warning about ordered factors as labels
david-cortes Feb 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
linter
  • Loading branch information
@david-cortes
david-cortes committed Feb 11, 2023
commit d05d2a63b23f36a3d326ad6936ab765c7039fe58
10 changes: 5 additions & 5 deletions R-package/tests/testthat/test_basic.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3541,8 +3541,8 @@ test_that("lightgbm() changes objective='auto' appropriately", {
x = model$save_model_to_string()
, split = "\n"
)[[1L]]
expect_true(any(grepl("objective=regression", model_txt_lines)))
expect_false(any(grepl("objective=regression_l1", model_txt_lines)))
expect_true(any(grepl("objective=regression", model_txt_lines, fixed = TRUE)))
expect_false(any(grepl("objective=regression_l1", model_txt_lines, fixed = TRUE)))

# Binary classification
x <- train$data
Expand All @@ -3553,7 +3553,7 @@ test_that("lightgbm() changes objective='auto' appropriately", {
x = model$save_model_to_string()
, split = "\n"
)[[1L]]
expect_true(any(grepl("objective=binary", model_txt_lines)))
expect_true(any(grepl("objective=binary", model_txt_lines, fixed = TRUE)))

# Multi-class classification
data("iris")
Expand All @@ -3566,7 +3566,7 @@ test_that("lightgbm() changes objective='auto' appropriately", {
x = model$save_model_to_string()
, split = "\n"
)[[1L]]
expect_true(any(grepl("objective=multiclass", model_txt_lines)))
expect_true(any(grepl("objective=multiclass", model_txt_lines, fixed = TRUE)))
})

test_that("lightgbm() determines number of classes for non-default multiclass objectives", {
Expand All @@ -3580,7 +3580,7 @@ test_that("lightgbm() determines number of classes for non-default multiclass ob
x = model$save_model_to_string()
, split = "\n"
)[[1L]]
expect_true(any(grepl("objective=multiclassova", model_txt_lines)))
expect_true(any(grepl("objective=multiclassova", model_txt_lines, fixed = TRUE)))
})

test_that("lightgbm() doesn't accept binary classification with non-binary factors", {
Expand Down