-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] [R-package] Add a few more linters #5311
[ci] [R-package] Add a few more linters #5311
Conversation
Includes following linters - any_duplicated_linter() - inner_combine_linter() - literal_coercion_linter() - missing_argument_linter() - numeric_leading_zero_linter() - outer_negation_linter() - package_hooks_linter() - sprintf_linter() - regex_subset_linter() - unreachable_code_linter() - vector_logic_linter() These required no changes to the code base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent, thank you! I'm especially excited about unreachable_code_linter()
and sprintf_linter()
. Those catch issues that can sometimes be difficult to find during code review.
@CuriousCorrelation I've changed the title of this PR to "Add a few more linters". The detail that these are all in one PR because they require no changes to the codebase is very useful information for reviewers, but I don't think it's important for users of the project when looking through release notes. In this project, PR titles automatically become items in the release notes (e.g. https://github.com/microsoft/LightGBM/releases/tag/v3.3.0). |
@jameslamb Yeah I noticed the entry in |
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
any_is_na_linter
toany_is_na
as per rest of the linter convention.of #5303