Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] [R-package] Add a few more linters #5311

Merged
merged 2 commits into from
Jun 20, 2022
Merged

[ci] [R-package] Add a few more linters #5311

merged 2 commits into from
Jun 20, 2022

Conversation

CuriousCorrelation
Copy link
Contributor

  1. Fixes any_is_na_linter to any_is_na as per rest of the linter convention.
  2. Completes following tasks
    • any_duplicated_linter()
    • inner_combine_linter()
    • literal_coercion_linter()
    • missing_argument_linter()
    • numeric_leading_zero_linter()
    • outer_negation_linter()
    • package_hooks_linter()
    • sprintf_linter()
    • regex_subset_linter()
    • unreachable_code_linter()
    • vector_logic_linter()

of #5303

Includes following linters

- any_duplicated_linter()
- inner_combine_linter()
- literal_coercion_linter()
- missing_argument_linter()
- numeric_leading_zero_linter()
- outer_negation_linter()
- package_hooks_linter()
- sprintf_linter()
- regex_subset_linter()
- unreachable_code_linter()
- vector_logic_linter()

These required no changes to the code base
@CuriousCorrelation CuriousCorrelation changed the title [ci] [R-package] Add several linter that require no change to codebase [ci] [R-package] Add several linters that require no change to codebase Jun 20, 2022
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you! I'm especially excited about unreachable_code_linter() and sprintf_linter(). Those catch issues that can sometimes be difficult to find during code review.

@jameslamb jameslamb changed the title [ci] [R-package] Add several linters that require no change to codebase [ci] [R-package] Add a few more linters Jun 20, 2022
@jameslamb
Copy link
Collaborator

@CuriousCorrelation I've changed the title of this PR to "Add a few more linters". The detail that these are all in one PR because they require no changes to the codebase is very useful information for reviewers, but I don't think it's important for users of the project when looking through release notes.

In this project, PR titles automatically become items in the release notes (e.g. https://github.com/microsoft/LightGBM/releases/tag/v3.3.0).

@jameslamb jameslamb merged commit aaac829 into microsoft:master Jun 20, 2022
@CuriousCorrelation
Copy link
Contributor Author

@jameslamb Yeah I noticed the entry in vsts-ci config, so it makes perfect sense. Also that's a very well made setup!
Thank you for taking time to explain the changes.

@CuriousCorrelation CuriousCorrelation deleted the lint/no-changes branch June 22, 2022 10:46
@jameslamb jameslamb mentioned this pull request Oct 7, 2022
40 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants