Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Promote objective and init_score to top-level arguments in lightgbm() #4976

Merged
merged 12 commits into from
Feb 23, 2022
Merged

[R-package] Promote objective and init_score to top-level arguments in lightgbm() #4976

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e8daef7
promote objective and init_score to top-level arguments
david-cortes Jan 23, 2022
f8fd193
follow comments
david-cortes Feb 13, 2022
72ea359
Update R-package/R/lightgbm.R
david-cortes Feb 13, 2022
d2a8a8b
update docs
david-cortes Feb 13, 2022
a7acc8a
linter
david-cortes Feb 13, 2022
069375d
comments
david-cortes Feb 14, 2022
f18fdb8
comments
david-cortes Feb 16, 2022
ca8b24b
solve merge conflict
david-cortes Feb 18, 2022
7e41805
comments
david-cortes Feb 19, 2022
b97841b
extend test for default objective
david-cortes Feb 20, 2022
2e5a749
Merge branch 'master' into Rinterface7
jameslamb Feb 23, 2022
1eeaca5
Update R-package/tests/testthat/test_basic.R
jameslamb Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update R-package/tests/testthat/test_basic.R
  • Loading branch information
@jameslamb
jameslamb authored Feb 23, 2022
commit 1eeaca58c5163a6e481aac4a2d69fe6d016601fb
1 change: 0 additions & 1 deletion R-package/tests/testthat/test_basic.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2910,7 +2910,6 @@ test_that("lightgbm() defaults to 'regression' objective if objective not otherw
, verbose = -1L
)
expect_equal(bst$params$objective, "regression")
jameslamb marked this conversation as resolved.
Show resolved Hide resolved
expect_equal(bst$params$objective, "regression")
model_txt_lines <- strsplit(
x = bst$save_model_to_string()
, split = "\n"
Expand Down