[R-package] quote path variables in build-cran-package.sh #4499
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LightGBM provides a script,
build-cran-package.sh
, which can be used to produce a CRAN-style source distribution of the R package.This is effectively user-facing code, since we encourage users to run it while developing or building from
master
to get unreleased features (e.g. #4259 (comment), #4464 (comment)).I realized yesterday, working on #3946 , that that script can break if called from a path that has spaces in it.
Consider the following:
This errors out like so:
This PR proposes quoting all shell variables in that script which include paths, which prevents this problem.