Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log warnings for number of bins of categorical features #4448

Merged
merged 4 commits into from
Mar 27, 2022
Merged

Log warnings for number of bins of categorical features #4448

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3f914f0
log warnings when number of bins of categorical features exceeds the …
shiyu1994 Jul 6, 2021
4195aa4
log only one warning information for all categorical features
shiyu1994 Jul 6, 2021
7568b9d
Add #include <memory> for unique_ptr
shiyu1994 Jul 6, 2021
7742572
remove useless param description
shiyu1994 Jul 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove useless param description
  • Loading branch information
@shiyu1994
shiyu1994 committed Jul 7, 2021
commit 7742572a9ca4f8041303bb58ad0a5f0cce8cdffb
1 change: 0 additions & 1 deletion include/LightGBM/bin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ class BinMapper {
* \param use_missing True to enable missing value handle
* \param zero_as_missing True to use zero as missing value
* \param forced_upper_bounds Vector of split points that must be used (if this has size less than max_bin, remaining splits are found by the algorithm)
* \param feature_name Feature name of this feature, for displaying warning information
*/
void FindBin(double* values, int num_values, size_t total_sample_cnt, int max_bin, int min_data_in_bin, int min_split_data, bool pre_filter, BinType bin_type,
bool use_missing, bool zero_as_missing, const std::vector<double>& forced_upper_bounds);
Expand Down