Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deterministic, part2 #3578

Merged
merged 2 commits into from
Nov 23, 2020
Merged

fix deterministic, part2 #3578

merged 2 commits into from
Nov 23, 2020

Conversation

guolinke
Copy link
Collaborator

fix #3372

@guolinke guolinke mentioned this pull request Nov 18, 2020
Closed
@StrikerRUS
Copy link
Collaborator

@guolinke Shouldn't OpenMP loops be executed in case of !deterministic_?

@StrikerRUS StrikerRUS added the fix label Nov 18, 2020
guolinke
guolinke commented Nov 19, 2020
View reviewed changes
src/objective/binary_objective.hpp Outdated Show resolved Hide resolved
src/objective/binary_objective.hpp Outdated Show resolved Hide resolved
src/objective/regression_objective.hpp Outdated Show resolved Hide resolved
src/objective/regression_objective.hpp Outdated Show resolved Hide resolved
src/objective/xentropy_objective.hpp Outdated Show resolved Hide resolved
src/objective/xentropy_objective.hpp Outdated Show resolved Hide resolved
src/objective/xentropy_objective.hpp Outdated Show resolved Hide resolved
src/objective/xentropy_objective.hpp Outdated Show resolved Hide resolved
@guolinke guolinke merged commit 5285974 into master Nov 23, 2020
@StrikerRUS StrikerRUS deleted the determinstic2 branch November 23, 2020 11:25
@StrikerRUS StrikerRUS mentioned this pull request Mar 30, 2021
Merged
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@btrotta btrotta Awaiting requested review from btrotta

@chivee chivee Awaiting requested review from chivee

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

instability caused by floating point errors
2 participants
@guolinke @StrikerRUS