[R-package] fixed evaluation on valids in lightgbm() (fixes #2915) #2916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guolinke
reviewed
Mar 21, 2020
| , "eval_freq" = eval_freq | ||
| , "early_stopping_rounds" = early_stopping_rounds | ||
| , "init_model" = init_model | ||
| , "callbacks" = callbacks |
There was a problem hiding this comment.
ah, yes! Good catch. I'll add that and a test on it
There was a problem hiding this comment.
oh wait @guolinke no I have it!
train_args <- append(train_args, list(...))
There was a problem hiding this comment.
and it's being tested already because in my tests I have metric = "binary_error" (and metric is not a keyword argument of the lightgbm() function)
guolinke
reviewed
Mar 21, 2020
| , early_stopping_rounds = early_stopping_rounds | ||
| , init_model = init_model | ||
| , callbacks = callbacks | ||
| , ... |
guolinke
approved these changes
Mar 22, 2020
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2915 for details. Getting evaluation on validation sets with the
lightgbm()function is currently broken. In this PR, I propose a fix and a test to prevent us from re-introducing the bug.