Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] adding routine registration in R package (fixes #1910) #2911

Merged
merged 28 commits into from
Apr 1, 2020
Merged

[R-package] adding routine registration in R package (fixes #1910) #2911

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
f7475d7
[R-package] started cutting over from custom R-to-C interface to R.h
jameslamb Feb 29, 2020
874a259
replaced LGBM_SE with SEXP
jameslamb Mar 11, 2020
42eca15
fixed error about ocnflicting definitions of length
jameslamb Mar 11, 2020
0960dd6
got linking working
jameslamb Mar 11, 2020
d08b960
more stuff
jameslamb Mar 11, 2020
d1dac98
eliminated R CMD CHECK note about printing
jameslamb Mar 12, 2020
0852023
switched from hard-coded include dir to the one from FindLibR.cmake
jameslamb Mar 12, 2020
b459a96
commented-out everything in CI that does not touch R
jameslamb Mar 12, 2020
c278fa9
more changes
jameslamb Mar 12, 2020
c2084e1
trying to get better logs
jameslamb Mar 12, 2020
3ffa91b
tried ignoring
jameslamb Mar 12, 2020
1875977
added error message to confirm a suspicion
jameslamb Mar 12, 2020
5a56d5e
restore full CI
jameslamb Mar 12, 2020
2eefb18
[R-package] started adding routine registration in R package
jameslamb Mar 12, 2020
34f04e9
more registrations
jameslamb Mar 12, 2020
3031bf2
added all functions
jameslamb Mar 13, 2020
cd42051
Eliminated note about registering routines
jameslamb Mar 13, 2020
b2ace3b
started cleaning up
jameslamb Mar 13, 2020
060ee94
reverted SEXP stuff
jameslamb Mar 13, 2020
76ec14b
more cleanup
jameslamb Mar 13, 2020
13db6bf
fixed linting
jameslamb Mar 14, 2020
3be19b4
cleaned up whitespace
jameslamb Mar 24, 2020
346a497
Update CMakeLists.txt
jameslamb Mar 25, 2020
80906c5
cleaned up handling of R package
jameslamb Mar 25, 2020
d88c3e3
fixed bad reference
jameslamb Mar 25, 2020
0238904
fixed list of SOURCES
jameslamb Mar 25, 2020
c6894c6
removed unnecessary linking
jameslamb Mar 28, 2020
1666f67
better use of source_dir and build_dir
jameslamb Apr 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed bad reference
  • Loading branch information
@jameslamb
jameslamb committed Apr 1, 2020
commit d88c3e351a8bda2b49ca94ded04b6007db6665a0
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ set(SOURCES "${SOURCES} src/c_api.cpp")
# Only build the R part of the library if building for
# use with the R package
if(BUILD_FOR_R)
set(SOURCES "${SOURCES} lightgbm_R.cpp")
set(SOURCES "${SOURCES} src/lightgbm_R.cpp")
endif(BUILD_FOR_R)

add_library(_lightgbm SHARED ${SOURCES})
Expand Down