Enforce R-package dependencies in build_r.R before compilation begins #1672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laurae2
reviewed
Sep 16, 2018
build_r.R
Outdated
| required = c("testthat", "roxygen2", "devtools") | ||
| ) | ||
| pkgs$missing = setdiff(pkgs$required, pkgs$installed) | ||
| if(length(pkgs$missing) > 0){ |
Laurae2
reviewed
Sep 16, 2018
build_r.R
Outdated
| message = paste0( | ||
| "The following R-packages are required for ", | ||
| "the LightGBM R-package install: \n", | ||
| paste0(pkgs_string, collapse = ''), |
There was a problem hiding this comment.
"" instead of '' for consistency
jameslamb
requested changes
Sep 16, 2018
jameslamb
approved these changes
Sep 16, 2018
Laurae2
approved these changes
Sep 23, 2018
|
@jameslamb To merge? |
|
@Laurae2 yep looks good to me! I'll merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found myself forgetting to install a couple of R-package dependencies repeatedly on successive LightGBM installations. This wasted some time because compilation runs for quite a while before getting to the part where these packages are required.