Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Help fixing #1540 #1638

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Help fixing #1540 #1638

merged 3 commits into from
Sep 5, 2018

Conversation

Laurae2
Copy link
Contributor

@Laurae2 Laurae2 commented Sep 3, 2018

Help fix #1540 reported bug (seq -> sep)

@Laurae2 Laurae2 requested a review from jameslamb September 3, 2018 18:34
jameslamb
jameslamb approved these changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jameslamb jameslamb mentioned this pull request Sep 3, 2018
Closed
@Laurae2
Copy link
Contributor Author

Laurae2 commented Sep 3, 2018

Waiting for checks to pass then we can push.

@jameslamb
Copy link
Collaborator

@Laurae2 I was going to make a PR for the other file bit, but since you're already doing it will leave my notes here.

I think this would be a better way to do the file check:

identical(class(data), "character") && length(data) == 1

Right now something like c("abc", "def") would make it through your check.

@Laurae2
Copy link
Contributor Author

Laurae2 commented Sep 4, 2018

@StrikerRUS docs and VS 2015 failed?

@StrikerRUS
Copy link
Collaborator

@Laurae2 Refer to #1635 (comment) for docs. Speaking about Appveyor, I have no idea why it failed even without any logs.
Lets trigger new build by closing and reopening the PR, since we have no access to rebuilding button at Appveyor.

@StrikerRUS StrikerRUS closed this Sep 4, 2018
@StrikerRUS StrikerRUS reopened this Sep 4, 2018
@StrikerRUS
Copy link
Collaborator

Opps... Builds for the branch haven't been re-triggered.
Need help of @guolinke or @chivee to rebuild Appveor.

@chivee chivee closed this Sep 5, 2018
@chivee chivee reopened this Sep 5, 2018
@Laurae2 Laurae2 merged commit 5970267 into master Sep 5, 2018
@Laurae2 Laurae2 deleted the fix-1540 branch September 5, 2018 16:26
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[LightGBM] [Fatal] Data file doesn't exist
4 participants
@Laurae2 @jameslamb @StrikerRUS @chivee