Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Singlethread make to lower RAM usage significantly #1141

Merged
merged 2 commits into from
Dec 27, 2017
Merged

[R-package] Singlethread make to lower RAM usage significantly #1141

merged 2 commits into from
Dec 27, 2017

Conversation

Laurae2
Copy link
Contributor

@Laurae2 Laurae2 commented Dec 25, 2017

Fixes #1125.

To merge when tested (currently being tested) - will drop a msg in this PR when it's tested.

@Laurae2 Laurae2 requested a review from guolinke December 25, 2017 10:23
@Laurae2
Copy link
Contributor Author

Laurae2 commented Dec 25, 2017

@wsnavely @guolinke Can you test the MinGW / gcc compilation and report if it uses only 1 thread? I have VS 2017 installed on all my computers unfortunately.

Use this code to install from my fork:

devtools::install_github("Laurae2/LightGBM@fix-1125", subdir = "R-package")

@guolinke
Copy link
Collaborator

-j1 may is too small ? it seems -j4 is widely-used.

@Laurae2
Copy link
Contributor Author

Laurae2 commented Dec 26, 2017

@guolinke -j4 apparently crashes my AMD E-350 laptop (embedded 64-bit device dual core 1 GHz, 3 GB RAM). LightGBM uses too much RAM (the VS compiler uses only 1 core)

@guolinke
Copy link
Collaborator

okay, however, you can you make directly, without -j1.

@guolinke guolinke merged commit a5f43c9 into microsoft:master Dec 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "make -j" in R installation
2 participants