Skip to content

bug: sjd fails on detect runtime #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mwc360 merged 2 commits into from
Jan 20, 2026
+11 −4
Merged

bug: sjd fails on detect runtime #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef16f89
remove ipython dependency as it isn't recognized in an SJD or spark s…
mwc360 Jan 20, 2026
e08d97a
bump version
mwc360 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"

[project]
name = "lakebench"
version = "0.13.0"
version = "0.13.1"
authors = [
{ name="Miles Cole" },
]
Expand Down
13 changes: 10 additions & 3 deletions src/lakebench/engines/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,13 @@ def _detect_runtime(self) -> str:

# Check for Microsoft Fabric or Synapse
try:
notebookutils = get_ipython().user_ns.get("notebookutils") # noqa: F821
notebookutils = None
utils_modules = ('notebookutils', 'mssparkutils')
for utils_module in utils_modules:
try:
notebookutils = __import__(utils_module)
except ImportError:
continue
if notebookutils and hasattr(notebookutils, 'runtime'):
if hasattr(notebookutils.runtime, 'context'):
context = notebookutils.runtime.context
Expand All @@ -119,11 +125,12 @@ def _detect_runtime(self) -> str:

# Check for Databricks
try:
dbutils = None
if 'DATABRICKS_RUNTIME_VERSION' in os.environ:
return "databricks"
try:
dbutils = get_ipython().user_ns.get("dbutils") # noqa: F821
if dbutils:
dbutils = __import__('dbutils')
if dbutils is not None:
return "databricks"
except:
pass
Expand Down