Add Japanese tokenizer (fugashi) and minimal unit test#223
Open
supernaiter wants to merge 1 commit intomicrosoft:mainfrom
Open
Add Japanese tokenizer (fugashi) and minimal unit test#223supernaiter wants to merge 1 commit intomicrosoft:mainfrom
supernaiter wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
Hi @iofu728 @SiyunZhao — This is a minimal PR to support Japanese prompt tokenization. Would love your feedback or approval when convenient. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds minimal support for Japanese prompt tokenization.
What's included:
tokenize_jp) using fugashi + unidic-liteis_japanese_text) to supportlang="auto"setup.pyupdated withextras_require["ja"]to optionally install Japanese dependenciesThis is the first step toward enabling Japanese prompt compression, designed to be self-contained and safe to merge.
Future work (e.g., integration into
compress_prompt) will follow as separate PRs.Fixes: N/A
Before submitting
Who can review?
@iofu728 @SiyunZhao — this is a minimal PR for Japanese support.
Would love your input before we follow up with
lang="ja"integration.