This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
BUG: Fix broken deployments + delicate envs #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #82
Makes fairly drastic changes to the python environment setup. Currently deployments are failing when attempting to install pip packages due to the fact that the underlying Linux image for the app service has changed, something we have no control over unless we create a custom Dockerfile (not practical for current and future non-technical users). App Service images are fixed to a specific Linux and Python version (currently Ubuntu 18.04 and python 3.7.15) and only install the packages specified in
requirements.txtinto a virtualenv using theantenvtool.Fixing the incompatible package versions would only be a temporary fix until this happens again. Instead here I am proposing to put only the primary dependencies in
requirements.txt, which allows much more flexible environment creation and avoids these issues, while also adding a nightly build + test to catch any future issues that may arise from secondary dependencies.To-Do: