Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

Make updates to avoid lightning deprecation warnings #751

Open

Description

🚀 Feature

Update packages and/or InnerEye code, so as not to have lightning deprecation warnings.

Motivation

When running the InnerEye code (commit b42043f), the following deprecation warnings are issued:

pytorch_lightning/callbacks/model_checkpoint.py:244: LightningDeprecationWarning: `ModelCheckpoint(every_n_val_epochs)` is deprecated in v1.4 and will be removed in v1.6. Please use `every_n_epochs` instead.
pytorch_lightning/core/lightning.py:399: LightningDeprecationWarning: `self.log(sync_dist_op='mean')` is deprecated and will be removed in v.1.6. Use `self.log(reduce_fx=mean)` instead.
pytorch_lightning/loggers/base.py:337: LightningDeprecationWarning: `LightningLoggerBase.close` method is deprecated in v1.5 and will be removed in v1.7. Please use `LightningLoggerBase.finalize` instead.

Pitch

It would be nice if packages and/or code could be updated so as to avoid the deprecation warnings - and to be future ready :)

Alternatives

There's probably a way of switching off the warnings, but addressing them would be better than hiding them.

Additional context

The deprecation warnings can be obtained by running the HelloWorld model, as outlined in README.md:

export PYTHONPATH=`pwd`
python InnerEye/ML/runner.py --model=HelloWorld

AB#6281

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    • Status

      No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions