Add support for .xctestproducts and Test Plan
#606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidAsulin1
requested review from
lifesaver0129,
zhou9584,
TedaLIEz,
olivershen-wow and
DexterDreeeam
as code owners
|
@DavidAsulin1 Again, thank you for the contribution, on behalf of the team. Would you mind adding a UT that can cover the changed branches in the code? |
|
/azp run |
|
No pipelines are associated with this pull request. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
zhou9584
reviewed
Oct 8, 2023
common/src/main/java/com/microsoft/hydralab/common/entity/common/TestTask.java
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@hydraxman The changes I made are better suited for Integration Testing rather than Unit Testing. I updated the private |
zhou9584
approved these changes
Nov 7, 2023
olivershen-wow
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I suggest adding support for the
.xctestproductspackage in XCTest. As I described in issue #583, usingxctestproductsis more suitable for CI and also supports the Test Plan feature.Currently, in order to export the test products, one needs to package the Derived Data and the
.xctestrunfile. After this change, the user can choose to upload thexctestproductspackage, and we will detect it internally.One additional change on the UI side is regarding the Test Plan name. In case the test type is XCTest, the user can enter the test plan name, which we will use if the test package is of type
xctestproducts.If we decide to proceed with this change, the Wiki page will need to be updated.
Linked GitHub issue ID: #583
Pull Request Checklist
Does this introduce a breaking change?
If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.
How you tested it
I test the change locally by uploading
xctestproductspackage and by choosing different test plans to executePlease check the type of change your PR introduces: