Skip to content

Conversation

@olivershen-wow
Copy link
Contributor

@olivershen-wow olivershen-wow commented Jun 19, 2023

Linked GitHub issue ID: #

Pull Request Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Code compiles correctly with all tests are passed.
  • I've read the contributing guide and followed the recommended practices.
  • Wikis or README have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

If this introduces a breaking change for Hydra Lab users, please describe the impact and migration path.

  • Yes
  • No

Pull Request Description

A few words to explain your changes:

  • Remove Windows restriction for command running on Agents.
  • Add AGENT type for the list of deviceActions to run on an agent separately, rather than being run together with commands for all or mobile devices (to ensure being run only once per test).

How you tested it

Please make sure the change is tested, you can test it by adding UTs, do local test and share the screenshots, etc.
Tested locally. See screenshot as below

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Technical design
  • Build related changes
  • Refactoring (no functional changes, no api changes)
  • Code style update (formatting, renaming) or Documentation content changes
  • Other (please describe):

Feature UI screenshots or Technical design diagrams

If this is a relatively large or complex change, kick it off by drawing the tech design with PlantUML and explaining why you chose the solution you did and what alternatives you considered, etc...
image

…separately, rather than being run together with commands for all or mobile devices (to ensure being run only once per test).
@olivershen-wow olivershen-wow marked this pull request as ready for review June 20, 2023 03:55
@olivershen-wow olivershen-wow enabled auto-merge (squash) June 20, 2023 06:10
@olivershen-wow olivershen-wow merged commit 1a26a8e into main Jun 20, 2023
@olivershen-wow olivershen-wow deleted the user/lsh/linux-agent-compatibility branch June 20, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants