Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify docs homepage snap points #3485

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Modify docs homepage snap points #3485

merged 2 commits into from
Sep 3, 2020

Conversation

skylerjokiel
Copy link
Contributor

Remove the md snap point that causes an odd transition. Going from sm to large gives a nicer flow from mobile to desktop.

currently you get into a common desktop place that looks like this. This change removes it.

image

tylerbutler
tylerbutler approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@tylerbutler tylerbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕺

@skylerjokiel skylerjokiel merged commit bd04189 into microsoft:main Sep 3, 2020
nmsimons
nmsimons reviewed Sep 3, 2020
View reviewed changes
Copy link
Contributor

@nmsimons nmsimons left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you including the compiled files in this PR?

Because some devs can't/don't compile the SCSS apparently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmsimons nmsimons nmsimons left review comments

@tylerbutler tylerbutler tylerbutler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skylerjokiel @tylerbutler @nmsimons