test(client-presence): minor typing and lint cleanup

packages/framework/presence/src/test/testUtils.ts

@@ -135,14 +135,14 @@ export type ProcessSignalFunction = ReturnType<typeof createPresenceManager>["pr
  * @param attendeeId - the client session id given to presence
  * @param clientConnectionId - the client connection id
  * @param clock - the fake timer.
- * @param logger - optional logger to track telemetry events
+ * @param logger - logger to track telemetry events
  */
 export function prepareConnectedPresence(
 	runtime: MockEphemeralRuntime,
 	attendeeId: string,
 	clientConnectionId: ClientConnectionId,
 	clock: Omit<SinonFakeTimers, "restore">,
-	logger?: EventAndErrorTrackingLogger,
+	logger: EventAndErrorTrackingLogger,
 ): {
 	presence: PresenceWithNotifications;
 	processSignal: ProcessSignalFunction;
@@ -154,7 +154,7 @@ export function prepareConnectedPresence(
 	runtime.clientId = clientConnectionId;
 	runtime.joined = true;
 
-	logger?.registerExpectedEvent({ eventName: "Presence:PresenceInstantiated" });
+	logger.registerExpectedEvent({ eventName: "Presence:PresenceInstantiated" });
 
 	// This logic needs to be kept in sync with datastore manager.
 	// From PresenceDatastoreManager.getInteractiveMembersExcludingSelf:
@@ -201,6 +201,7 @@ export function prepareConnectedPresence(
 		// the network and Presence can safely mutate it.
 		presence.processSignal(
 			addressChain,
+			// eslint-disable-next-line unicorn/prefer-structured-clone -- not structural clone, but filters to JSON-serializable data
 			JSON.parse(JSON.stringify(signalMessage)) as InboundExtensionMessage<SignalMessages>,
 			local,
 		);
@@ -255,7 +256,7 @@ export function prepareConnectedPresence(
  */
 export function assertFinalExpectations(
 	runtime: MockEphemeralRuntime,
-	logger?: EventAndErrorTrackingLogger,
+	logger: EventAndErrorTrackingLogger,
 ): void {
 	// Make sure all expected events were logged and there are no unexpected errors.
 	const logErrors = getUnexpectedLogErrorException(logger);