Shared Tree: Additional tests for schema compatibility cases #25883
+65
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: dds
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Outdated
Show resolved
Hide resolved
…tyChecker.spec.ts Co-authored-by: Craig Macomber (Microsoft) <42876482+CraigMacomber@users.noreply.github.com>
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Show resolved
Hide resolved
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Show resolved
Hide resolved
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Show resolved
Hide resolved
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Outdated
Show resolved
Hide resolved
| const backwardsCompatibilityStatus = checkCompatibility(oldViewSchema, currentViewSchema); | ||
|
|
||
| // The staged string schema in the old schema is supported in the current schema | ||
| assert.equal(backwardsCompatibilityStatus.canView, true); |
Contributor
There was a problem hiding this comment.
If this is true, we have a major issue. This should require an upgrade to add support for strings. If it does not, then new clients could add strings to a document whose stored schema does not support them, which is invalid.
packages/dds/tree/src/test/simple-tree/api/snapshotCompatibilityChecker.spec.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up for #25861.
Description
This change adds tests around a couple interesting compatibility cases:
allowUnknownOptionalFieldsto allow for forward compatibility. This is the case where the original schema specifies that it can view content persisted with future schemas whose fields it does not know.