Skip to content

Conversation

markfields
Copy link
Member

@markfields markfields commented Sep 26, 2025

Description

Fixes AB#46428

This test intentionally ignores server interactions (specifically it doesn't measure the op roundtrip time), so it shouldn't matter which service it runs against. We have seen some flakiness against FRS so drop that variant.

@Copilot Copilot AI review requested due to automatic review settings September 26, 2025 23:43
@github-actions github-actions bot added the area: tests Tests to add, test infrastructure improvements, etc label Sep 26, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes flakiness issues with the op critical path benchmark test by excluding FRS (Fluid Relay Service) and R11s variants. Since the test intentionally ignores server interactions and doesn't measure op roundtrip time, the specific service used shouldn't affect the benchmark results.

  • Adds conditional skipping for R11s and routerlicious driver types
  • Changes arrow function to regular function to access this.skip()

Comment on lines +62 to 70
beforeEach("conditionalSkip", async function () {
if (provider.driver.type === "r11s" || provider.driver.type === "routerlicious") {
this.skip(); // This test is not reliable with FRS for some reason
}
});

const setup = async () => {
testId++;
provider = getTestObjectProvider();
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The provider variable is not defined at this point in the test lifecycle. The provider is assigned in the setup() function which is called in the before hook, but this beforeEach runs before setup(). This will cause a runtime error when accessing provider.driver.type.

Suggested change
beforeEach("conditionalSkip", async function () {
if (provider.driver.type === "r11s" || provider.driver.type === "routerlicious") {
this.skip(); // This test is not reliable with FRS for some reason
}
});
const setup = async () => {
testId++;
provider = getTestObjectProvider();
// Removed beforeEach conditionalSkip; logic moved to setup()
const setup = async function () {
testId++;
provider = getTestObjectProvider();
if (provider.driver.type === "r11s" || provider.driver.type === "routerlicious") {
// This test is not reliable with FRS for some reason
this.skip?.();
return;
}

Copilot uses AI. Check for mistakes.

@github-actions github-actions bot added the base: main PRs targeted against main branch label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant