improvement(fluid-build): Add a spinner with additional info for incremental task checks #23282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.
Files not reviewed (1)
- build-tools/packages/build-tools/package.json: Language not supported
tylerbutler
commented
Jan 10, 2025
alexvy86
reviewed
Jan 13, 2025
| @@ -532,11 +533,14 @@ export class BuildGraph { | |||
| return succeeded; | |||
| } | |||
|
|
|||
| public async build(timer?: Timer): Promise<BuildResult> { | |||
| public async build(timer?: Timer, spinner?: Spinner): Promise<BuildResult> { | |||
There was a problem hiding this comment.
Does it need to be passed as a parameter? In this case the caller starts and finishes its use of it so it seems like it wouldn't cause issues, but in general it feels like this would be better off being its own instance so it doesn't potentially interfere with the one passed in (if that one was still in progress, for example)?
There was a problem hiding this comment.
I honestly have no idea why I did it that way... fixed in latest.
alexvy86
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a CLI spinner to display a little more feedback when loading the build graph and checking incremental tasks. Currently fluid-build just sits there for awhile and looks like it's hung. There is more that we could do, but this is a step in the right direction.