Fix type test generation issues #22989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
CraigMacomber
commented
Nov 5, 2024
| @@ -44,16 +44,19 @@ export function toTypeString( | |||
| // does the type take generics that don't have defaults? | |||
| // eslint-disable-next-line unicorn/no-lonely-if -- logic is clearer when grouped this way. | |||
| if ( | |||
| node.getTypeParameters().length > 0 && | |||
There was a problem hiding this comment.
this check is redundant with the one following it so it was removed.
jatgarg
approved these changes
Nov 5, 2024
Josmithr
pushed a commit
that referenced
this pull request
Nov 5, 2024
## Description generic types with an extends clause of `never` currently generate type tests which do not compile due to any not extending never. This is fixed by using `never` instead of `any`. `@system` types which do not promise user facing stability are now omitted from type testing. The currently unused tags to opt into alternative type testing for a given type have been converted from `-` separated to camel case since it seems `-` does not work well in tags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
generic types with an extends clause of
nevercurrently generate type tests which do not compile due to any not extending never. This is fixed by usingneverinstead ofany.@systemtypes which do not promise user facing stability are now omitted from type testing.The currently unused tags to opt into alternative type testing for a given type have been converted from
-separated to camel case since it seems-does not work well in tags.Reviewer Guidance
The review process is outlined on this wiki page.