Skip to content

AppConfigurationEvaluationEvent Schema#33

Merged
mrm9084 merged 1 commit intomainfrom
AppConfigFeatureEvaluationEvent
Jun 27, 2025
Merged

AppConfigurationEvaluationEvent Schema#33
mrm9084 merged 1 commit intomainfrom
AppConfigFeatureEvaluationEvent

Conversation

@mrm9084
Copy link
Contributor

@mrm9084 mrm9084 commented Jun 19, 2025

Separates the unique values that come from App Configuration from those when just using the feature management library.

@mrm9084 mrm9084 requested review from Copilot and jimmyca15 June 19, 2025 16:47
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates the app configuration–specific properties from the generic feature evaluation event schema.

  • Removes "AllocationId", "ETag", and "FeatureFlagReference" from the base FeatureEvaluationEvent schema.
  • Introduces a new AppConfigurationFeatureEvaluationEvent schema that reintroduces these properties with required validations.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json Removed app configuration–specific properties to decouple them from the base schema.
Schema/FeatureEvaluationEvent/AppConfigurationFeatureEvaluationEventv1.0.0.schema.json Introduced a new schema extending the base and re-adding the removed properties with strict validations.
Comments suppressed due to low confidence (2)

Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json:72

  • Removing 'AllocationId', 'ETag', and 'FeatureFlagReference' from the base schema could break consumers that rely on them. Please ensure that a migration plan or clear documentation for consumers is provided.
    },

Schema/FeatureEvaluationEvent/AppConfigurationFeatureEvaluationEventv1.0.0.schema.json:9

  • [nitpick] Since the base schema no longer includes 'AllocationId', 'ETag', and 'FeatureFlagReference', reconsider whether referencing it via allOf is necessary or if the schema could be simplified by defining only the relevant properties.
      "$ref": "FeatureEvaluationEvent.v1.0.0.schema.json"

@mrm9084 mrm9084 merged commit e71e4a4 into main Jun 27, 2025
6 checks passed
@mrm9084 mrm9084 deleted the AppConfigFeatureEvaluationEvent branch June 27, 2025 18:57
@mrm9084 mrm9084 restored the AppConfigFeatureEvaluationEvent branch July 8, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants