Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the FeatureEvaluationEvent schema to include new fields for version 1.0.0.
- Adds new properties: DefaultWhenEnabled, Version, VariantAssignmentPercentage, AllocationId, ETag, and FeatureFlagReference
- Sets default version and numeric bounds for variant assignment percentage
- Extends schema metadata to support the 1.0.0 event specification
Comments suppressed due to low confidence (1)
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json:60
- If
DefaultWhenEnabledmust always be present in the event, add it to the schema'srequiredarray; otherwise confirm it’s intentionally optional.
"DefaultWhenEnabled": {
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
Outdated
Show resolved
Hide resolved
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
Outdated
Show resolved
Hide resolved
Member
|
This should be a new version 1.1.0 |
Member
We discussed keeping 1.0.0 due to the fact that the actual implementation of 1.0.0 in feature management libraries had all of these additional fields. |
jimmyca15
reviewed
Jun 13, 2025
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
Outdated
Show resolved
Hide resolved
jimmyca15
reviewed
Jun 13, 2025
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
Jun 13, 2025
…hema.json Co-authored-by: Jimmy Campbell <jimmyca@microsoft.com>
jimmyca15
reviewed
Jun 16, 2025
jimmyca15
reviewed
Jun 16, 2025
Schema/FeatureEvaluationEvent/FeatureEvaluationEvent.v1.0.0.schema.json
Outdated
Show resolved
Hide resolved
jimmyca15
approved these changes
Jun 16, 2025
jimmyca15
approved these changes
Jun 16, 2025
jimmyca15
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the schema to have the latest fields of the 1.0.0 version.