Skip to content

Use the raw url so VSCode can parse the reference#31

Merged
zhiyuanliang-ms merged 2 commits intomicrosoft:mainfrom
b-barthel:patch-1
May 7, 2025
Merged

Use the raw url so VSCode can parse the reference#31
zhiyuanliang-ms merged 2 commits intomicrosoft:mainfrom
b-barthel:patch-1

Conversation

@b-barthel
Copy link
Contributor

VScode cannot parse the referenced schema because it points to an HTML page. By using the raw url we can get the JSON instead.

VScode cannot parse the referenced schema because it points to an HTML page.  By using the raw url we can get the JSON instead.
@b-barthel
Copy link
Contributor Author

I tested by creating a json file in vscode with the $schema set to each version:
"$schema": "https://raw.githubusercontent.com/b-barthel/FeatureManagement/refs/heads/patch-1/Schema/FeatureManagement.v2.0.0.schema.json",
vs
"$schema": "https://raw.githubusercontent.com/microsoft/FeatureManagement/refs/heads/main/Schema/FeatureManagement.v2.0.0.schema.json",

the updated reference url loads fine, while the original gives an error:

Problems loading reference 'https://github.com/microsoft/FeatureManagement/blob/c5fab16dbf1450dce0bbfe7c4207da735ff31916/Schema/FeatureFlag.v2.0.0.schema.json': Unable to parse content from 'https://github.com/microsoft/FeatureManagement/blob/c5fab16dbf1450dce0bbfe7c4207da735ff31916/Schema/FeatureFlag.v2.0.0.schema.json': Parse error at offset 6.(768)

@zhiyuanliang-ms
Copy link
Member

Hey, @b-barthel Thanks for calling this out.

Can you also update this the 1.0.0 schema: here

Copy link
Member

@zhiyuanliang-ms zhiyuanliang-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All schema ref url should be updated.

@b-barthel
Copy link
Contributor Author

@zhiyuanliang-ms - updated, can you merge, I don't have permissions.

@zhiyuanliang-ms zhiyuanliang-ms merged commit 1121c3b into microsoft:main May 7, 2025
6 checks passed
@zhiyuanliang-ms
Copy link
Member

Thank you for the contribution! @b-barthel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants