Conversation
avanigupta
reviewed
Dec 17, 2024
| }, | ||
| "telemetry": { | ||
| "enabled": "true", | ||
| "enabled": true, |
Member
There was a problem hiding this comment.
Would this break any test?
If not, maybe we should add a test to validate this.
Contributor
Author
There was a problem hiding this comment.
Maybe a better question for @rossgrambo or @zhiyuanliang-ms. I've updated all of them to be Boolean in this PR, but Python and Spring don't care if they are Strings or Booleans and just make them work.
Member
There was a problem hiding this comment.
It does break JS FM. I correct some of them in this PR
But I haven't use BasicTelemetry sample yet, as it was added recently.
Member
|
I'm seeing multiple sample files with feature_flags.enabled property set to string true/false instead of boolean. For example: Should we add some tests to validate that boolean types dont get string values assigned? |
zhiyuanliang-ms
approved these changes
Jan 10, 2025
jimmyca15
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.