Skip to content

Added Accessor #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 3, 2025
Merged

Added Accessor #55

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5a287e1
Added Accessor with comments
mrm9084 Jan 30, 2025
27d14d5
comment and format change
mrm9084 Jan 30, 2025
44f9c60
fixing log
mrm9084 Jan 30, 2025
f50965b
fixing log length
mrm9084 Jan 30, 2025
9a7ec69
async version with tests
mrm9084 Jan 31, 2025
161df0f
fix test and pylint issue
mrm9084 Jan 31, 2025
6660854
Update featuremanagement/aio/_featuremanager.py
mrm9084 Feb 3, 2025
04516b7
Update _featuremanager.py
mrm9084 Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing log length
  • Loading branch information
@mrm9084
mrm9084 committed Jan 30, 2025
commit f50965b0bc48a6668e0abd9f46e1f8e2157e8b94
3 changes: 2 additions & 1 deletion featuremanagement/_featuremanagerbase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,8 @@ def _build_targeting_context(self, args: Tuple[Any]) -> TargetingContext:
if targeting_context and isinstance(targeting_context, TargetingContext):
return targeting_context
logging.warning(
f"targeting_context_accessor did not return a TargetingContext. Received type {type(targeting_context)}."
"targeting_context_accessor did not return a TargetingContext. Received type %s.",
type(targeting_context),
)
return TargetingContext()

Expand Down