Skip to content

Support telemetry processor & initializer #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 21, 2025
Merged

Support telemetry processor & initializer #98

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f7a306a
support targeting context accessor
zhiyuanliang-ms Feb 6, 2025
aa54818
add test
zhiyuanliang-ms Feb 6, 2025
7e26524
fix lint
zhiyuanliang-ms Feb 6, 2025
0c7c1a5
update
zhiyuanliang-ms Feb 6, 2025
f612aad
update
zhiyuanliang-ms Feb 6, 2025
730bb2e
export targeting context
zhiyuanliang-ms Feb 10, 2025
b9bcbc9
add comments
zhiyuanliang-ms Feb 10, 2025
a94fd84
support telemetry processor & initializer
zhiyuanliang-ms Feb 10, 2025
401b41f
Merge branch 'preview' of https://github.com/microsoft/FeatureManagem…
zhiyuanliang-ms Mar 26, 2025
08c037c
Merge branch 'preview' into zhiyuanliang/telemetry-processor
zhiyuanliang-ms Apr 18, 2025
325fbef
update
zhiyuanliang-ms Apr 21, 2025
f6d60c1
update
zhiyuanliang-ms Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@zhiyuanliang-ms
zhiyuanliang-ms committed Feb 6, 2025
commit 0c7c1a52f2be5e83c61ad59b29c75c605c12d5cb
2 changes: 1 addition & 1 deletion src/feature-management/test/targetingFilter.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ describe("targeting filter", () => {

let userId = "";
let groups: string[] = [];
const testTargetingContextAccessor = () => ({ userId, groups });
const testTargetingContextAccessor = () => ({ userId: userId, groups: groups });
const provider = new ConfigurationMapFeatureFlagProvider(dataSource);
const featureManager = new FeatureManager(provider, {targetingContextAccessor: testTargetingContextAccessor});

Expand Down
4 changes: 2 additions & 2 deletions src/feature-management/test/variant.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@
describe("variant assignment with targeting context accessor", () => {
it("should assign variant based on targeting context accessor", async () => {
let userId = "";
const groups: string[] = [];
const testTargetingContextAccessor = () => ({ userId, groups });
let groups: string[] = [];

Check failure on line 98 in src/feature-management/test/variant.test.ts

View workflow job for this annotation

GitHub Actions / build (18.x) 

'groups' is never reassigned. Use 'const' instead

Check failure on line 98 in src/feature-management/test/variant.test.ts

View workflow job for this annotation

GitHub Actions / build (20.x) 

'groups' is never reassigned. Use 'const' instead
const testTargetingContextAccessor = () => ({ userId: userId, groups: groups });
const provider = new ConfigurationObjectFeatureFlagProvider(featureFlagsConfigurationObject);
const featureManager = new FeatureManager(provider, {targetingContextAccessor: testTargetingContextAccessor});
userId = "Marsha";
Expand Down
Loading