Skip to content

initialize project with basic feature management support #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 27, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comments about overriding filters with same name
  • Loading branch information
Eskibear committed Mar 8, 2024
commit 30c599d1dc8d039acd6866c951291c1ac44e75a1
6 changes: 4 additions & 2 deletions src/featureManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ export class FeatureManager {
constructor(provider: IFeatureFlagProvider, options?: FeatureManagerOptions) {
this.#provider = provider;

const defaultFilters = [new TimewindowFilter()];
for (const filter of [...defaultFilters, ...(options?.customFilters ?? [])]) {
const builtinFilters = [new TimewindowFilter()];

// If a custom filter shares a name with an existing filter, the custom filter overrides the existing one.
for (const filter of [...builtinFilters, ...(options?.customFilters ?? [])]) {
this.#featureFilters.set(filter.name, filter);
}
}
Expand Down