Skip to content

Validate settings if BindParameters is not called #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Validate settings if BindParameters is not called #429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b92cd8
validate settings if BindParameters is not called
zhiyuanliang-ms Apr 16, 2024
50cbb2e
Merge branch 'preview' into zhiyuanliang/validate-settings-if-no-preb…
zhiyuanliang-ms Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/Microsoft.FeatureManagement/Targeting/ContextualTargetingFilter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,13 @@ public Task<bool> EvaluateAsync(FeatureFilterEvaluationContext context, ITargeti
// Check if prebound settings available, otherwise bind from parameters.
TargetingFilterSettings settings = (TargetingFilterSettings)context.Settings ?? (TargetingFilterSettings)BindParameters(context.Parameters);

//
// If prebound settings is not available, which means BindParameters method is not called, we need to validate the feature filter settings.
if (context.Settings == null && !TargetingEvaluator.TryValidateSettings(settings, out string paramName, out string reason))
{
throw new ArgumentException(reason, paramName);
}

return Task.FromResult(TargetingEvaluator.IsTargeted(targetingContext, settings, _options.IgnoreCase, context.FeatureName));
}
}
Expand Down